net/http: fix zombie connection leaked #51615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lesismal wants to merge 1 commit into golang:master from lesismal:master

lesismal commented Mar 11, 2022

When Server.IdleTimeout is not zero and after the first request, the client sends part of the data of a full request, and the data is no less than 4 bytes, the idle timeout which has been set will be reset to zero here and would never close the conn:
https://github.com/golang/go/blob/master/src/net/http/server.go#L1996

Fixes #51614

Contributor

gopherbot commented Mar 11, 2022

This PR (HEAD: 7a0aa0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/391836 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Mar 11, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/391836.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 11, 2022

Message from Rhys Hiltner:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/391836.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 11, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/391836.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 11, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/391836.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 11, 2022

Message from Rhys Hiltner:

Patch Set 1: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/391836.
After addressing review feedback, remember to publish your drafts!


          net/http: fix zombie connection leaked

7346d20

When `Server.IdleTimeout` is not zero and after the first request, the client sends part of the data of a full request, and the data is no less than 4 bytes, the idle timeout which has been set will be reset to zero here and would never close the conn:
https://github.com/golang/go/blob/master/src/net/http/server.go#L1996

lesismal force-pushed the master branch from 7a0aa0f to 7346d20 Compare

March 12, 2022 10:51

Contributor

gopherbot commented Mar 12, 2022

This PR (HEAD: 7346d20) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/391836 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

lesismal closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet